Skip to content

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Oct 18, 2019

closes #171

Description

  • adds label prop to form, same as title
  • updates docs

@rvsia rvsia added enhancement New feature or request renderer React form renderer PR docs docs pull requests labels Oct 18, 2019
@rvsia rvsia requested review from skateman and Hyperkid123 October 18, 2019 14:11
@codecov-io
Copy link

Codecov Report

Merging #172 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   81.33%   81.34%   +0.01%     
==========================================
  Files          87       87              
  Lines        1382     1383       +1     
  Branches      332      333       +1     
==========================================
+ Hits         1124     1125       +1     
  Misses        214      214              
  Partials       44       44
Impacted Files Coverage Δ
...ges/react-form-renderer/src/form-renderer/index.js 75% <100%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5758020...b44d669. Read the comment docs.

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman
Copy link
Member

@rvsia it's a minor problem and I'm not a designer, but IMO the top-level label should be bigger than the label on the sub-form. With the same analogy as the individual labels for inputs are smaller than labels for sub-forms.

top-level > sub-form > input
h1 > h3 > label

@rvsia
Copy link
Contributor Author

rvsia commented Oct 18, 2019

@skateman I agree, this was added only as a placeholder.

const TitleWrapper = ({ children }) => <h3>{ children }</h3>;
Here, you can change it.

@Hyperkid123 Hyperkid123 merged commit 690e0d0 into data-driven-forms:master Oct 22, 2019
@rvsia rvsia deleted the add_label_to_form branch March 5, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs docs pull requests enhancement New feature or request renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistency in top-level attributes of the schema
4 participants