Allow array value select #180
Conversation
|
@Hyperkid123 does this mean that I have to use the |
|
@skateman |
| @@ -164,6 +170,7 @@ Select.defaultProps = { | |||
| }, | |||
| loadingMessage: 'Loading...', | |||
| simpleValue: true, | |||
| pluckSingleValue: true, | |||
There was a problem hiding this comment.
This could bring some incompatibility issue, if someone uses an actual array as a value for the select.
There was a problem hiding this comment.
Yep i though of that. Check the rest of the code and tests 😉
There was a problem hiding this comment.
I thought that if someone has options like this right now:
[
{ value: ['apple', 'pineapple'], label: 'sweet'},
{ value: ['chocolate','kitkat'], label: 'best'},
] Then he should have to set this prop to false and that (he will need to change the schema) will break the backwards compatibility. Am I right?
There was a problem hiding this comment.
The example you posted would not work at this point because we were using === to select the value from options instead if isEqual. So nobody could use it successfully
|
Okay, then I just have to try it 😉 |
|
|
||
| |prop name|type|description| | ||
| |---------|----|-----------| | ||
| |pluckSingleValue|`bool`|If a value is an array, component will pick its first item and set it as a new value. This will override the value in state from `[2, 4, 5]` to `2` for example.| |
There was a problem hiding this comment.
It should be said that it is a true by default
Hyperkid123
force-pushed
the
allow-array-value-select
branch
from
4a813bc to
32438b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 81.52% 81.53% +0.01%
==========================================
Files 87 87
Lines 1380 1397 +17
Branches 333 336 +3
==========================================
+ Hits 1125 1139 +14
- Misses 211 214 +3
Partials 44 44
Continue to review full report at Codecov.
|
closes #179
Changes
pluckSingleValuefor pf3 select[2, 4, 5]will result into2as a value in form state