-
Notifications
You must be signed in to change notification settings - Fork 91
fix(pf3): stop date picker crash when value is string. #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a3cbe3a
to
43a0857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hyperkid123 Could you please write a little test? Thanks! 🌮
ups forgot add the WIP thing Working on it right now. |
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 81.74% 83.03% +1.28%
==========================================
Files 87 87
Lines 1397 1397
Branches 344 344
==========================================
+ Hits 1142 1160 +18
+ Misses 211 197 -14
+ Partials 44 40 -4
Continue to review full report at Codecov.
|
Now it's throwing me {
"component": "date-picker",
"name": "date-picker-1",
"label": "Datepicker 1",
"visible": true,
"disabledDays": [
{
"before": "today"
}
],
"variant": "date"
} And by clicking on the picker icon, it crashes with |
@skateman ah there is one mor thing i forgot |
87a5abf
to
7a347a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hyperkid123 what about to add a test that proves that |
@rvsia the crash has nothing to do with the clicl but with the fact the it was sending string to the day picker component instead of Date object. |
closes #189
Day picker can now accept value as a string.