-
Notifications
You must be signed in to change notification settings - Fork 91
Use select componsition to style pf3 select #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff61483
to
c204f9e
Compare
c204f9e
to
0fd05bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=========================================
+ Coverage 81.54% 82.45% +0.9%
=========================================
Files 88 93 +5
Lines 1783 1824 +41
Branches 604 607 +3
=========================================
+ Hits 1454 1504 +50
+ Misses 329 320 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🏆
@Hyperkid123 Looks great, however, the code coverage decreased too much. Could you add some test to increase it please? |
i will once i am able |
🎉 This PR is included in version 1.25.0 🎉 The release is available on Demo can be found here! |
Changes
@rvsia @skateman this was a lot of refactoring and lof of the internal logic has changed. I would appreciate it if you could test this very thoroughly since there is a high chance that I've missed something. Even though the tests might pass I would like to test it manually.