Skip to content

Convert component examples to mdx #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Jan 14, 2020

  • Component pages are converted into MDX
  • Header is set in the MDX, not in the component itself

Should help Algolia to crawl these pages

@rvsia rvsia added the docs docs pull requests label Jan 14, 2020
@rvsia rvsia requested a review from Hyperkid123 January 14, 2020 10:02
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #279 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #279   +/-   ##
======================================
  Coverage    85.5%   85.5%           
======================================
  Files          95      95           
  Lines        1863    1863           
  Branches      620     620           
======================================
  Hits         1593    1593           
  Misses        270     270

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db17980...554a17a. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit c144501 into data-driven-forms:master Jan 14, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 1.25.2 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the convert-jscomponents-to-mdx branch March 5, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs docs pull requests released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants