Skip to content

MUI mapper audit fix #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 10, 2020
Merged

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Jan 29, 2020

#295

fixes #303

Fixes formFields components

  • Wizard will be done seperately
  • Select still needs to be converrted into common select with loadOptions and other fancy stuff

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #296 into master will increase coverage by 4.07%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   86.75%   90.83%   +4.07%     
==========================================
  Files          97       97              
  Lines        1895     1909      +14     
  Branches      617      631      +14     
==========================================
+ Hits         1644     1734      +90     
+ Misses        251      175      -76
Impacted Files Coverage Δ
...i-component-mapper/src/form-fields/select-field.js 73.17% <100%> (+73.17%) ⬆️
...ent-mapper/src/form-fields/multiple-choice-list.js 100% <100%> (ø) ⬆️
packages/common/src/multiple-choice-list.js 100% <100%> (ø) ⬆️
...ages/mui-component-mapper/src/form-fields/radio.js 87.5% <66.66%> (+87.5%) ⬆️
...ui-component-mapper/src/form-fields/form-fields.js 94.54% <93.75%> (+94.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33da85...a4dcbee. Read the comment docs.

@rvsia rvsia force-pushed the addMissingTestsForMUI branch from 7441ab1 to 99e1c15 Compare February 7, 2020 12:02
@rvsia rvsia changed the title [WIP] Add missing tests MUI mapper [WIP] MUI mapper audit fix Feb 7, 2020
@rvsia rvsia requested a review from Hyperkid123 February 10, 2020 10:05
@rvsia rvsia changed the title [WIP] MUI mapper audit fix MUI mapper audit fix Feb 10, 2020
@rvsia rvsia added bug Something isn't working enhancement New feature or request MUI MUI pull request labels Feb 10, 2020
@rvsia rvsia force-pushed the addMissingTestsForMUI branch from adac3f2 to 499989f Compare February 10, 2020 11:40
Copy link
Member

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvsia did you check if there are console error with unknown dom properties?

@rvsia
Copy link
Contributor Author

rvsia commented Feb 10, 2020

@Hyperkid123 should be clear

@rvsia rvsia force-pushed the addMissingTestsForMUI branch from 499989f to a4dcbee Compare February 10, 2020 12:48
@Hyperkid123 Hyperkid123 merged commit 1fc6b9b into data-driven-forms:master Feb 10, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 1.27.6 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the addMissingTestsForMUI branch March 5, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request MUI MUI pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use helperText for error messages instead of label in mui
2 participants