Skip to content

fix(pf4): Multi async select initial value change. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

fix(pf4): Multi async select initial value change. #298

merged 1 commit into from
Jan 31, 2020

Conversation

Hyperkid123
Copy link
Member

No description provided.

@Hyperkid123 Hyperkid123 added bug Something isn't working PF4 PF4 pull request labels Jan 31, 2020
@Hyperkid123 Hyperkid123 requested a review from rvsia January 31, 2020 08:27
@codecov
Copy link

codecov bot commented Jan 31, 2020 •
edited
Loading

Codecov Report

Merging #298 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   86.73%   86.76%   +0.03%     
==========================================
  Files          97       97              
  Lines        1892     1897       +5     
  Branches      619      623       +4     
==========================================
+ Hits         1641     1646       +5     
  Misses        251      251
Impacted Files Coverage Δ
...-component-mapper/src/form-fields/select/select.js 91.17% <100%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a07fe4a...56dfdde. Read the comment docs.

rvsia
rvsia approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏞️

@rvsia rvsia merged commit 168ac7d into master Jan 31, 2020
@Hyperkid123 Hyperkid123 deleted the fix-pf4-async-multi branch January 31, 2020 08:54
@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 1.27.2 🎉

The release is available on

Demo can be found here!

@Hyperkid123 Hyperkid123 mentioned this pull request Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvsia rvsia rvsia approved these changes

Assignees
No one assigned
Labels
bug Something isn't working PF4 PF4 pull request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hyperkid123 @rvsia