Skip to content

fix(pf4): use tree shaking for PF4 dep #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Feb 3, 2020

No description provided.

@rvsia rvsia added the PF4 PF4 pull request label Feb 3, 2020
@rvsia rvsia requested a review from Hyperkid123 February 3, 2020 09:58
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files          97       97           
  Lines        1897     1897           
  Branches      623      623           
=======================================
  Hits         1646     1646           
  Misses        251      251
Impacted Files Coverage Δ
...pf4-component-mapper/src/form-fields/plain-text.js 100% <ø> (ø) ⬆️
...ent-mapper/src/form-fields/multiple-choice-list.js 100% <ø> (ø) ⬆️
...ponent-mapper/src/form-fields/wizard/wizard-nav.js 100% <ø> (ø) ⬆️
...nent-mapper/src/form-fields/wizard/step-buttons.js 93.75% <ø> (ø) ⬆️
...f4-component-mapper/src/form-fields/form-fields.js 97.72% <ø> (ø) ⬆️
...-component-mapper/src/form-fields/wizard/wizard.js 100% <ø> (ø) ⬆️
...onent-mapper/src/form-fields/wizard/wizard-step.js 100% <ø> (ø) ⬆️
...ages/pf4-component-mapper/src/form-fields/radio.js 100% <ø> (ø) ⬆️
...-component-mapper/src/form-fields/select/option.js 58.33% <ø> (ø) ⬆️
...t-mapper/src/form-fields/select/clear-indicator.js 80% <ø> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168ac7d...3447e27. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 3354777 into data-driven-forms:master Feb 3, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 1.27.3 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the shakethattree branch March 5, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF4 PF4 pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants