Skip to content

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Mar 12, 2020

  • tests

@rvsia rvsia added bug Something isn't working renderer React form renderer PR V2 labels Mar 12, 2020
@rvsia rvsia force-pushed the enhanceOnCancelReset branch from 6308abb to 3ad8b0b Compare March 12, 2020 11:44
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #375 into v2 will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #375      +/-   ##
==========================================
+ Coverage   87.15%   87.32%   +0.17%     
==========================================
  Files         132      132              
  Lines        2179     2177       -2     
  Branches      690      689       -1     
==========================================
+ Hits         1899     1901       +2     
+ Misses        280      276       -4
Impacted Files Coverage Δ
...onent-mapper/src/components/wizard/step-buttons.js 93.33% <ø> (-0.42%) ⬇️
...ages/pf4-component-mapper/src/components/wizard.js 100% <100%> (ø) ⬆️
packages/common/src/form-template.js 94.44% <100%> (+9.07%) ⬆️
...eact-form-renderer/src/components/form-renderer.js 95.65% <100%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a72fc1...82174ed. Read the comment docs.

@rvsia rvsia force-pushed the enhanceOnCancelReset branch from 3ad8b0b to 4b9cb2a Compare March 12, 2020 11:50
@rvsia rvsia requested a review from Hyperkid123 March 12, 2020 11:50
@rvsia rvsia changed the title [WIP] [V2] Enhance on cancel reset [V2] Enhance on cancel reset Mar 12, 2020
@rvsia rvsia force-pushed the enhanceOnCancelReset branch from 4b9cb2a to 82174ed Compare March 12, 2020 12:03
@Hyperkid123 Hyperkid123 merged commit daae740 into data-driven-forms:v2 Mar 12, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 1.31.0 🎉

The release is available on

Demo can be found here!

@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the enhanceOnCancelReset branch April 28, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released renderer React form renderer PR V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants