Skip to content

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Mar 17, 2020

Removes predictSteps from PF4 wizard. It's always true. (There is no reason to not show all steps in the navigation, when it's possible.)

@rvsia rvsia added enhancement New feature or request PF4 PF4 pull request V2 labels Mar 17, 2020
@rvsia rvsia requested a review from Hyperkid123 March 17, 2020 13:11
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #384 into v2 will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #384      +/-   ##
==========================================
- Coverage   87.82%   87.80%   -0.03%     
==========================================
  Files         133      133              
  Lines        2202     2198       -4     
  Branches      702      699       -3     
==========================================
- Hits         1934     1930       -4     
  Misses        268      268              
Impacted Files Coverage Δ
...ages/pf4-component-mapper/src/components/wizard.js 100.00% <100.00%> (ø)
...-component-mapper/src/components/wizard/reducer.js 96.87% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72dbd9...b258cb1. Read the comment docs.

@Hyperkid123
Copy link
Member

@rvsia looks good. Can you also update the migration guide?

@rvsia rvsia force-pushed the predictStepsDefault branch from 3b73e34 to b258cb1 Compare March 17, 2020 14:01
@rvsia
Copy link
Contributor Author

rvsia commented Mar 17, 2020

@Hyperkid123 done!

@Hyperkid123 Hyperkid123 merged commit 47b198b into data-driven-forms:v2 Mar 17, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 1.31.0 🎉

The release is available on

Demo can be found here!

@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the predictStepsDefault branch April 28, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PF4 PF4 pull request released V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants