[V2] refactor(renderer): refactor render single field #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvsia
changed the title
Codecov Report
@@ Coverage Diff @@
## v2 #385 +/- ##
=========================================
- Coverage 87.8% 87.77% -0.03%
=========================================
Files 133 132 -1
Lines 2198 2193 -5
Branches 699 699
=========================================
- Hits 1930 1925 -5
Misses 268 268
Continue to review full report at Codecov.
|
rvsia
changed the title
Hyperkid123
approved these changes
Mar 18, 2020
|
🎉 This PR is included in version 1.31.0 🎉 The release is available on Demo can be found here! |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on Demo can be found here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field wrapper is unnecessary layer => merged with render single field + refactoring for cleaner code