Skip to content

Conversation

Hyperkid123
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #388 into v2 will increase coverage by 0.60%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #388      +/-   ##
==========================================
+ Coverage   87.79%   88.39%   +0.60%     
==========================================
  Files         132      132              
  Lines        2196     2181      -15     
  Branches      701      700       -1     
==========================================
  Hits         1928     1928              
+ Misses        268      253      -15     
Impacted Files Coverage Δ
...mui-component-mapper/src/common/form-field-grid.js 100.00% <ø> (ø)
...omponent-mapper/src/common/multiple-choice-list.js 100.00% <ø> (ø)
...ackages/mui-component-mapper/src/files/checkbox.js 100.00% <ø> (ø)
...mui-component-mapper/src/files/component-mapper.js 100.00% <ø> (ø)
...ages/mui-component-mapper/src/files/date-picker.js 0.00% <ø> (ø)
...es/mui-component-mapper/src/files/form-template.js 81.81% <ø> (ø)
...kages/mui-component-mapper/src/files/plain-text.js 100.00% <ø> (ø)
packages/mui-component-mapper/src/files/radio.js 93.33% <ø> (ø)
packages/mui-component-mapper/src/files/select.js 84.61% <ø> (ø)
...nent-mapper/src/files/select/integration-select.js 71.42% <ø> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f23ff...c2b01e8. Read the comment docs.

@Hyperkid123 Hyperkid123 requested a review from rvsia March 18, 2020 14:34
@Hyperkid123 Hyperkid123 force-pushed the streamline-build-output branch 2 times, most recently from 94a4c9f to 8963776 Compare March 20, 2020 09:38
@Hyperkid123 Hyperkid123 force-pushed the streamline-build-output branch from 8963776 to c2b01e8 Compare March 20, 2020 09:47
@Hyperkid123 Hyperkid123 changed the title [WIP][V2] Stream line build output files structure. [V2] Stream line build output files structure. Mar 20, 2020
@Hyperkid123
Copy link
Member Author

Hyperkid123 commented Mar 20, 2020

@rvsia I think it's ready. Checking if the docs still works would be a priority probably.

There should be no changes to the components themselves

Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see the date picker PF3 in demo, otherwise it looks good!

@Hyperkid123
Copy link
Member Author

Yeah that is the one thing that I cannot figure out. I wonder if that is only in SSR mode.

@rvsia
Copy link
Contributor

rvsia commented Mar 20, 2020

@Hyperkid123 so should we merge this?

@Hyperkid123
Copy link
Member Author

Hyperkid123 commented Mar 20, 2020

I don't know. We will have to deal with it later. And we should probably switch to the pf3 version of date time picker.

I would deal with this later.

@rvsia
Copy link
Contributor

rvsia commented Mar 20, 2020

@Hyperkid123 yeah, let’s merge it, it is still just a beta

@rvsia rvsia merged commit c0b9ca9 into v2 Mar 20, 2020
@Hyperkid123 Hyperkid123 deleted the streamline-build-output branch March 20, 2020 12:27
@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 1.31.0 🎉

The release is available on

Demo can be found here!

@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 2.0.0 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants