-
Notifications
You must be signed in to change notification settings - Fork 91
[V2] Stream line build output files structure. #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
526413c
to
0bd409f
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #388 +/- ##
==========================================
+ Coverage 87.79% 88.39% +0.60%
==========================================
Files 132 132
Lines 2196 2181 -15
Branches 701 700 -1
==========================================
Hits 1928 1928
+ Misses 268 253 -15
Continue to review full report at Codecov.
|
94a4c9f
to
8963776
Compare
8963776
to
c2b01e8
Compare
@rvsia I think it's ready. Checking if the docs still works would be a priority probably. There should be no changes to the components themselves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see the date picker PF3 in demo, otherwise it looks good!
Yeah that is the one thing that I cannot figure out. I wonder if that is only in SSR mode. |
@Hyperkid123 so should we merge this? |
I don't know. We will have to deal with it later. And we should probably switch to the pf3 version of date time picker. I would deal with this later. |
@Hyperkid123 yeah, let’s merge it, it is still just a beta |
🎉 This PR is included in version 1.31.0 🎉 The release is available on Demo can be found here! |
🎉 This PR is included in version 2.0.0 🎉 The release is available on Demo can be found here! |
No description provided.