Skip to content

fix(renderer): add buttonType to form controls #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Mar 20, 2020

  • allows to customize each button depending on its type (submit, cancel, reset)
prop type desc value customization
buttonType string Depends on the type button One of 'submit', 'cancel', 'reset' No
  • also use link for PF4's cancel button

rvsia added 2 commits March 20, 2020 11:06
- allows to customize each button depending on its type (submit, cancel, reset)
@rvsia rvsia added enhancement New feature or request PF4 PF4 pull request renderer React form renderer PR labels Mar 20, 2020
@rvsia rvsia requested a review from Hyperkid123 March 20, 2020 10:09
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   91.64%   91.64%   +<.01%     
==========================================
  Files         100      100              
  Lines        2034     2035       +1     
  Branches      672      673       +1     
==========================================
+ Hits         1864     1865       +1     
  Misses        170      170
Impacted Files Coverage Δ
...ponent-mapper/src/form-fields/layout-components.js 92.3% <100%> (ø) ⬆️
...ponent-mapper/src/form-fields/layout-components.js 100% <100%> (ø) ⬆️
...t-form-renderer/src/form-renderer/form-controls.js 100% <100%> (ø) ⬆️
...ponent-mapper/src/form-fields/layout-components.js 66.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bff65...e1f5df2. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 09f902f into data-driven-forms:master Mar 20, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 1.30.1 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the buttonType branch April 28, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PF4 PF4 pull request released renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants