Skip to content

fix(pf4): wizard disable button on validating #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Apr 14, 2020

Same as #424

@rvsia rvsia added bug Something isn't working PF4 PF4 pull request labels Apr 14, 2020
@rvsia rvsia requested a review from Hyperkid123 April 14, 2020 08:24
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #426 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   88.88%   88.89%   +0.01%     
==========================================
  Files         135      135              
  Lines        2150     2153       +3     
  Branches      701      702       +1     
==========================================
+ Hits         1911     1914       +3     
  Misses        239      239              
Impacted Files Coverage Δ
...-component-mapper/src/files/wizard/step-buttons.js 94.44% <100.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21e818...01c49e4. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 9cd85b8 into data-driven-forms:master Apr 14, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.0.8 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the pf4wizardvalidating branch April 28, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PF4 PF4 pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants