Skip to content

Update docs examples #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 21, 2020
Merged

Update docs examples #443

merged 15 commits into from
Apr 21, 2020

Conversation

Hyperkid123
Copy link
Member

@Hyperkid123 Hyperkid123 commented Apr 21, 2020 •
edited
Loading

part of #440

@Hyperkid123 Hyperkid123 changed the title Update docs examples [WIP] Update docs examples Apr 21, 2020
@Hyperkid123 Hyperkid123 added the docs docs pull requests label Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020 •
edited
Loading

Codecov Report

Merging #443 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files         136      136           
  Lines        2295     2295           
  Branches      755      755           
=======================================
  Hits         2058     2058           
  Misses        237      237

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67a30d...a275148. Read the comment docs.

@Hyperkid123 Hyperkid123 force-pushed the move-exmaples branch 2 times, most recently from e1536ad to ce282d7 Compare April 21, 2020 13:10
@Hyperkid123 Hyperkid123 requested a review from rvsia April 21, 2020 14:40
@Hyperkid123 Hyperkid123 changed the title [WIP] Update docs examples Update docs examples Apr 21, 2020
rvsia
rvsia approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@rvsia rvsia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🏆

The only nitpick I have is that we could make mode="preview" default, because it's set almost everywhere.

(Otherwise, you can merge it, if you don't want to change it)

@Hyperkid123 Hyperkid123 merged commit 84fd128 into master Apr 21, 2020
@Hyperkid123
Copy link
Member Author

😈

@Hyperkid123 Hyperkid123 deleted the move-exmaples branch April 21, 2020 15:24
@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on

Demo can be found here!

@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 2.1.3 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvsia rvsia rvsia approved these changes

Assignees
No one assigned
Labels
docs docs pull requests released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hyperkid123 @rvsia