Skip to content

fix(pf4): use custom divs for dual list select #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 4, 2020
Merged

fix(pf4): use custom divs for dual list select #467

merged 3 commits into from
May 4, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented May 4, 2020

No native select anymore

  • fixed test warnings
  • clean isEqual from useFieldApi

Before

before

After

after

@rvsia rvsia added the bug Something isn't working label May 4, 2020
@rvsia rvsia requested a review from Hyperkid123 May 4, 2020 10:28
@rvsia rvsia added PF4 PF4 pull request renderer React form renderer PR labels May 4, 2020
@Hyperkid123 Hyperkid123 merged commit cb848f0 into data-driven-forms:master May 4, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.1.10 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the fixDualListSelectNative branch June 4, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees

@Hyperkid123 Hyperkid123

Labels
bug Something isn't working PF4 PF4 pull request released renderer React form renderer PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvsia @Hyperkid123