Skip to content

Add slider components #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2020
Merged

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented May 5, 2020

closes #472

TODO:

  • Renderer constant
  • MUI slider
  • PF3 slider
  • documentation

@rvsia rvsia added enhancement New feature or request PF3 MUI MUI pull request renderer React form renderer PR labels May 5, 2020
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #473 into master will increase coverage by 0.02%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   89.75%   89.77%   +0.02%     
==========================================
  Files         141      144       +3     
  Lines        2410     2435      +25     
  Branches      801      812      +11     
==========================================
+ Hits         2163     2186      +23     
- Misses        247      249       +2     
Impacted Files Coverage Δ
...mui-component-mapper/src/files/component-mapper.js 100.00% <ø> (ø)
...pf3-component-mapper/src/files/component-mapper.js 75.00% <ø> (ø)
...pf4-component-mapper/src/files/component-mapper.js 100.00% <ø> (ø)
...s/react-form-renderer/src/files/component-types.js 100.00% <ø> (ø)
packages/mui-component-mapper/src/files/slider.js 83.33% <83.33%> (ø)
...es/pf3-component-mapper/src/files/form-template.js 94.11% <100.00%> (+0.36%) ⬆️
packages/pf3-component-mapper/src/files/slider.js 100.00% <100.00%> (ø)
packages/pf4-component-mapper/src/files/slider.js 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c29a0...2c4078c. Read the comment docs.

@rvsia rvsia changed the title [WIP] Add slider components Add slider components May 6, 2020
@rvsia rvsia requested a review from Hyperkid123 May 6, 2020 08:19
@Hyperkid123
Copy link
Member

@rvsia can you add just a regular slider for PF4? So we have something in place until there is an existing component?

@Hyperkid123
Copy link
Member

I also see "1" character when previewing the PF3 slide:
screenshot-localhost_3000-2020 05 06-11_49_01

Can you check where is it coming from?

@Hyperkid123
Copy link
Member

It seems that the value is popping out (probably has some z-index value)
screenshot-localhost_3000-2020 05 06-11_50_24

@rvsia
Copy link
Contributor Author

rvsia commented May 6, 2020

@Hyperkid123 Yeah, the styling of the PF3 slider is wrong, but I did my best and copied all sliders CSS to our mastermind CSS file. It helped a lot, but it's not perfect. :-/

Yeah, I can add a placeholder to PF4.

@Hyperkid123
Copy link
Member

@rvsia can you override it so it does not mess up the docs?

@rvsia
Copy link
Contributor Author

rvsia commented May 6, 2020

@Hyperkid123

  1. added a PF4 slider

image

  1. the number in PF3 is hidden

@rvsia rvsia added the PF4 PF4 pull request label May 6, 2020
Copy link
Member

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nasty PF3 ghosts are gone

|-----|----|-----------|
|after|node|Node rendered after the slider|
|before|node|Node rendered before the slider|
|FormFieldGridProps|object|Props passed to FormFieldGrid component|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add links to the corresponding API of the MUI component? The rest of the MUI components does have this link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Hyperkid123 Hyperkid123 merged commit a62e22a into data-driven-forms:master May 6, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.3.0 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the addSlider branch June 4, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MUI MUI pull request PF3 PF4 PF4 pull request released renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Slider/range components
2 participants