-
Notifications
You must be signed in to change notification settings - Fork 91
Add slider components #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 89.75% 89.77% +0.02%
==========================================
Files 141 144 +3
Lines 2410 2435 +25
Branches 801 812 +11
==========================================
+ Hits 2163 2186 +23
- Misses 247 249 +2
Continue to review full report at Codecov.
|
@rvsia can you add just a regular slider for PF4? So we have something in place until there is an existing component? |
@Hyperkid123 Yeah, the styling of the PF3 slider is wrong, but I did my best and copied all sliders CSS to our mastermind CSS file. It helped a lot, but it's not perfect. :-/ Yeah, I can add a placeholder to PF4. |
@rvsia can you override it so it does not mess up the docs? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nasty PF3 ghosts are gone
|-----|----|-----------| | ||
|after|node|Node rendered after the slider| | ||
|before|node|Node rendered before the slider| | ||
|FormFieldGridProps|object|Props passed to FormFieldGrid component| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add links to the corresponding API of the MUI component? The rest of the MUI components does have this link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
🎉 This PR is included in version 2.3.0 🎉 The release is available on Demo can be found here! |
closes #472
TODO: