Skip to content

Merge ts beta #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 15, 2020
Merged

Merge ts beta #553

merged 31 commits into from
Jun 15, 2020

Conversation

Hyperkid123
Copy link
Member

This should bring the TS changes up to date with the latest PF updates. We can fix up the types from there.

This is an experimental commit to check build process and its ouput.
Circle CI was runing out of memory
- added AnyObject type for extensible props
- fixed component mapper expecting string instead of react component
- fixed useFieldApi return type to accept other props that input and meta
- fixed missing component type in form template
- fixed SormSpy not being exported as component
- added form template render props
- fixed wrong return type of useFormApi hook
- fixed field validator type schema definition
- fixed constants not properly exporting the definitions objecs
- fixed condtion type not allowing nested condition schema
- fixed FieldArray not exporting component type with props
- fixed field schema not allowing single condition
- fixed field schema not accepting actions object
- make form renderer extend final form props
- fixed Form type net being exported as react component
- fixed schema validator not accepting any arguments
- changed useFieldApi type input value default to any type
@Hyperkid123 Hyperkid123 requested a review from rvsia June 15, 2020 11:22
@Hyperkid123
Copy link
Member Author

I have removed @data-driven-forms/react-form-renderer from the mappers devDependencies. It was causing issues with released beta channels and it was installing a different version of the packages to node modules. That caused an invalid final form reference and everything blows up.

There is no need for listing local dependencies (we never released common but we are referencing it in all projects)

Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚎

@rvsia rvsia merged commit e102762 into beta Jun 15, 2020
@Hyperkid123 Hyperkid123 deleted the merge-ts-beta branch June 15, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants