Skip to content

Convert firebase object to array #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Jun 16, 2020

Objects are converted to arrays, so notifications can work again.

@rvsia rvsia added bug Something isn't working docs docs pull requests labels Jun 16, 2020
@rvsia rvsia requested a review from Hyperkid123 June 16, 2020 13:46
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files         189      189           
  Lines        2906     2906           
  Branches      952      952           
=======================================
  Hits         2724     2724           
  Misses        182      182           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f0fc7...9edc81e. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit b774389 into data-driven-forms:master Jun 16, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.5.1 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the convertNotToArray branch July 10, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs docs pull requests released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants