-
Notifications
You must be signed in to change notification settings - Fork 91
PF4 downshift select #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF4 downshift select #562
Conversation
d9774d4
to
b227500
Compare
429b037
to
791b090
Compare
The API should remain the same and I've removed the isRead only props. There is no input (by PF design) that can be read-only and there is no point giving that to a div which now holds the value. |
6ac48e5
to
f01be4d
Compare
f01be4d
to
bdd47bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
==========================================
- Coverage 93.75% 92.98% -0.77%
==========================================
Files 190 189 -1
Lines 2912 3008 +96
Branches 952 985 +33
==========================================
+ Hits 2730 2797 +67
- Misses 182 211 +29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! 🏆
However, there is one regression - isDisabled on option does not work. You can check the demo wizard schema. isDisabled is being used in sources.
Good catch. I will fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚜
🎉 This PR is included in version 2.6.2 🎉 The release is available on Demo can be found here! |
closes #560
Replace react selet with downshift.
Provides complete customization and has a much smaller impact on build size (around 24KB instead of 112KB)
Current progress