Skip to content

PF4 downshift select #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 29, 2020
Merged

PF4 downshift select #562

merged 14 commits into from
Jun 29, 2020

Conversation

Hyperkid123
Copy link
Member

@Hyperkid123 Hyperkid123 commented Jun 17, 2020

closes #560

Replace react selet with downshift.

Provides complete customization and has a much smaller impact on build size (around 24KB instead of 112KB)

Current progress

Screenshot from 2020-06-17 16-04-48

@Hyperkid123 Hyperkid123 added enhancement New feature or request PF4 PF4 pull request labels Jun 17, 2020
@Hyperkid123 Hyperkid123 force-pushed the pf4-downshift-select branch from d9774d4 to b227500 Compare June 25, 2020 11:57
@Hyperkid123 Hyperkid123 force-pushed the pf4-downshift-select branch from 429b037 to 791b090 Compare June 26, 2020 06:58
@Hyperkid123 Hyperkid123 requested a review from rvsia June 26, 2020 08:11
@Hyperkid123 Hyperkid123 changed the title [WIP] PF4 downshift select PF4 downshift select Jun 26, 2020
@Hyperkid123
Copy link
Member Author

The API should remain the same and I've removed the isRead only props. There is no input (by PF design) that can be read-only and there is no point giving that to a div which now holds the value.

@Hyperkid123 Hyperkid123 force-pushed the pf4-downshift-select branch from 6ac48e5 to f01be4d Compare June 26, 2020 08:13
@Hyperkid123 Hyperkid123 force-pushed the pf4-downshift-select branch from f01be4d to bdd47bf Compare June 26, 2020 08:15
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #562 into master will decrease coverage by 0.76%.
The diff coverage is 71.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   93.75%   92.98%   -0.77%     
==========================================
  Files         190      189       -1     
  Lines        2912     3008      +96     
  Branches      952      985      +33     
==========================================
+ Hits         2730     2797      +67     
- Misses        182      211      +29     
Impacted Files Coverage Δ
...ponent-mapper/src/common/select/clear-indicator.js 33.33% <20.00%> (-26.67%) ⬇️
...ges/pf4-component-mapper/src/common/select/menu.js 32.00% <32.00%> (ø)
...s/pf4-component-mapper/src/common/select/select.js 97.10% <96.96%> (+7.10%) ⬆️
...omponent-mapper/src/common/select/empty-options.js 100.00% <100.00%> (ø)
...es/pf4-component-mapper/src/common/select/input.js 100.00% <100.00%> (+100.00%) ⬆️
...s/pf4-component-mapper/src/common/select/option.js 100.00% <100.00%> (+45.45%) ⬆️
...ponent-mapper/src/common/select/value-container.js 100.00% <100.00%> (ø)
packages/common/src/select/parse-internal-value.js 88.88% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa9b98...33c9ccf. Read the comment docs.

Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! 🏆

However, there is one regression - isDisabled on option does not work. You can check the demo wizard schema. isDisabled is being used in sources.

@Hyperkid123
Copy link
Member Author

Looks and works great!

However, there is one regression - isDisabled on option does not work. You can check the demo wizard schema. isDisabled is being used in sources.

Good catch. I will fix it

Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚜

@rvsia rvsia merged commit e54a88f into master Jun 29, 2020
@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 2.6.2 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the pf4-downshift-select branch July 16, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PF4 PF4 pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PF4] Migrate away from react-select
2 participants