Skip to content

Fix types #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2020
Merged

Fix types #614

merged 3 commits into from
Jul 2, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Jul 2, 2020

SUIR

  • change datePicker to timePicker in timePicker types

MUI

  • add remaining type arguments to select

PF4

  • Remove unused import in PF4 wizard types

@rvsia rvsia added bug Something isn't working PF4 PF4 pull request MUI MUI pull request SUIR Semantic ui react mapper labels Jul 2, 2020
@rvsia rvsia requested a review from Hyperkid123 July 2, 2020 12:58
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         189      189           
  Lines        3008     3008           
  Branches      985      985           
=======================================
  Hits         2797     2797           
  Misses        211      211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d8fae...89d0df8. Read the comment docs.

@rvsia rvsia merged commit dcdbbcb into data-driven-forms:master Jul 2, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.6.6 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the fixTypes branch July 10, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees

@Hyperkid123 Hyperkid123

Labels
bug Something isn't working MUI MUI pull request PF4 PF4 pull request released SUIR Semantic ui react mapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvsia @Hyperkid123