Skip to content

Use pf4 select component #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Use pf4 select component #653

merged 2 commits into from
Jul 20, 2020

Conversation

Hyperkid123
Copy link
Member

This just ate my whole day!

Changes

  • use typeahead styling for PF4 select
  • add top cropping of the menu if the element is of the scrollable parent element (bottom is not needed since the the menu should overflow the parent)
  • add scroll overflow to the menu to prevent window overflow

zkurveny-select

@Hyperkid123 Hyperkid123 added bug Something isn't working PF4 PF4 pull request labels Jul 16, 2020
@Hyperkid123 Hyperkid123 requested a review from rvsia July 16, 2020 15:19
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #653 into master will decrease coverage by 0.94%.
The diff coverage is 38.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   93.37%   92.42%   -0.95%     
==========================================
  Files         212      189      -23     
  Lines        3258     3038     -220     
  Branches     1057      995      -62     
==========================================
- Hits         3042     2808     -234     
- Misses        216      230      +14     
Impacted Files Coverage Δ
...ges/pf4-component-mapper/src/common/select/menu.js 25.80% <13.04%> (-6.20%) ⬇️
...s/pf4-component-mapper/src/common/select/select.js 89.61% <58.33%> (-7.50%) ⬇️
...ponent-mapper/src/common/select/value-container.js 85.71% <80.00%> (-14.29%) ⬇️
...es/pf4-component-mapper/src/common/select/input.js 100.00% <100.00%> (ø)
...ages/ant-component-mapper/src/files/time-picker.js
...ages/ant-component-mapper/src/files/date-picker.js
packages/ant-component-mapper/src/files/wizard.js
packages/ant-component-mapper/src/files/select.js
...kages/ant-component-mapper/src/files/text-field.js
...-component-mapper/src/files/wizard/step-buttons.js
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146e2d3...e7c047e. Read the comment docs.

uiSchema={this.state.ui}
{...this.state.additionalOptions}
/>
<Modal isOpen variant="small" title="title">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please return the demo to normal version? :D

Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! 🏆

@Hyperkid123 Hyperkid123 force-pushed the use-pf4-select-component branch from e470fd6 to e7c047e Compare July 20, 2020 07:41
@Hyperkid123
Copy link
Member Author

done

@rvsia rvsia merged commit fdde12c into master Jul 20, 2020
@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 2.8.1 🎉

The release is available on

Demo can be found here!

@Hyperkid123 Hyperkid123 deleted the use-pf4-select-component branch July 23, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PF4 PF4 pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants