Skip to content

Pf4 select updates #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Pf4 select updates #660

merged 2 commits into from
Jul 27, 2020

Conversation

Hyperkid123
Copy link
Member

Fixes

  • pressing spacebar inside the searchable input toggled the menu (close/open)
    • the event is no longer propagated to input parent elements (toggle root)
  • added a check for the type of filter value
    • opening a menu with set input value from the initial value caused the menu to crash
    • it was trying to run toLowerCase on an array

@Hyperkid123 Hyperkid123 added bug Something isn't working PF4 PF4 pull request labels Jul 27, 2020
@Hyperkid123 Hyperkid123 requested a review from rvsia July 27, 2020 11:09
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #660 into master will decrease coverage by 0.07%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   92.85%   92.77%   -0.08%     
==========================================
  Files         212      212              
  Lines        3290     3296       +6     
  Branches     1069     1070       +1     
==========================================
+ Hits         3055     3058       +3     
- Misses        235      238       +3     
Impacted Files Coverage Δ
...es/pf4-component-mapper/src/common/select/input.js 66.66% <0.00%> (-33.34%) ⬇️
...s/pf4-component-mapper/src/common/select/select.js 90.00% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb9190...b807caa. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 90f65ce into master Jul 27, 2020
@Hyperkid123
Copy link
Member Author

🎉 This PR is included in version 2.8.4 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PF4 PF4 pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant