fix(pf4): Add customization api to plain text #697
Conversation
| @@ -4,11 +4,11 @@ import PropTypes from 'prop-types'; | |||
| import { TextContent, Text } from '@patternfly/react-core'; | |||
| import validTextFields from '@data-driven-forms/common/src/utils/valid-text-fields'; | |||
|
|
|||
| const PlainText = ({ label, name, variant }) => ( | |||
| <TextContent> | |||
| const PlainText = ({ label, name, variant, TextProps, TextContentProps }) => ( | |||
There was a problem hiding this comment.
I think TextProps should be changed to ...rest to make it consistent with the way we are spreading props in all other components. (...rest should be always spread to the main component.)
Just catch component props before you do it.
|
|
||
| export interface PlainTextProps { | ||
| label: ReactNode; | ||
| name: string; | ||
| variant?: 'p'|'span'|'strong'|'b'|'cite'|'caption'|'code'|'em'|'i'|'h1'|'h2'|'h3'|'h4'|'h5'|'h6'|'h6'|'div'|'label'|'pre'|'q'|'samp'|'small'|'sub'|'sup'; | ||
| TextProps: TextProps, | ||
| TextContentProps: TextContentProps, |
There was a problem hiding this comment.
Maybe we should add it do docs.
There was a problem hiding this comment.
Ah right its not generated yet.
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 212 212
Lines 3308 3308
Branches 1074 1074
=======================================
Hits 3067 3067
Misses 241 241
Continue to review full report at Codecov.
|
Hyperkid123
force-pushed
the
add-pf4-customization-api-plain-text
branch
from
11fada0 to
5c2ce24
Compare
| @@ -4,11 +4,11 @@ import PropTypes from 'prop-types'; | |||
| import { TextContent, Text } from '@patternfly/react-core'; | |||
| import validTextFields from '@data-driven-forms/common/src/utils/valid-text-fields'; | |||
|
|
|||
| const PlainText = ({ label, name, variant }) => ( | |||
| <TextContent> | |||
| const PlainText = ({ label, name, variant, TextContentProps, ...rest }) => ( | |||
There was a problem hiding this comment.
please catch 'component' prop coming from renderer, it could cause issues.
There was a problem hiding this comment.
I think this actually is closer to the current way of customization in our other mappers (stuff like required, disabled, etc.). Plus the component prop is always caught by the use field hook. And you can't really use the component key in the schema.
There was a problem hiding this comment.
The plaintext component will receive component="plain_text" and then this is passed via rest to the PF Text component. There is no useFieldApi hook here to catch it.
There was a problem hiding this comment.
we do not catch component in useFIeldApi!?
Yup its not interactive field 😆
There was a problem hiding this comment.
We do, but plain text is not using it. It's not a field, it's just a component.
| @@ -19,7 +19,8 @@ const PlainText = ({ label, name, variant }) => ( | |||
| PlainText.propTypes = { | |||
| variant: PropTypes.oneOf(validTextFields), | |||
There was a problem hiding this comment.
We should mention that component PF prop is mapped to variant prop in Docs.
Hyperkid123
force-pushed
the
add-pf4-customization-api-plain-text
branch
from
5c2ce24 to
d380c31
Compare
Hyperkid123
force-pushed
the
add-pf4-customization-api-plain-text
branch
from
d380c31 to
7d2da4c
Compare
|
🎉 This PR is included in version 2.8.9 🎉 The release is available on Demo can be found here! |
No description provided.