Skip to content

fix(manager): allow multiple isEqual for a field #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2020
Merged

fix(manager): allow multiple isEqual for a field #774

merged 1 commit into from
Sep 2, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Aug 31, 2020

closes #739

@rvsia rvsia added the State manager Form state manager packages. Will be used a state management package for the form renderer. label Aug 31, 2020
@rvsia rvsia requested a review from Hyperkid123 August 31, 2020 15:15
@Hyperkid123 Hyperkid123 mentioned this pull request Aug 31, 2020
Closed
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #774 into state-manager will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           state-manager     #774   +/-   ##
==============================================
  Coverage          93.17%   93.18%           
==============================================
  Files                223      223           
  Lines               3809     3813    +4     
  Branches            1189     1191    +2     
==============================================
+ Hits                3549     3553    +4     
  Misses               260      260
Impacted Files Coverage Δ
...ckages/form-state-manager/src/utils/manager-api.ts 95.63% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7d0f0...cfeb18a. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit c45ffa1 into data-driven-forms:state-manager Sep 2, 2020
@rvsia rvsia deleted the multipleIsEqual branch October 7, 2020 09:40
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 3.1.0 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees

@Hyperkid123 Hyperkid123

Labels
released State manager Form state manager packages. Will be used a state management package for the form renderer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvsia @Hyperkid123