fix(manager): convert initialValue/defaultValue when dataType #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvsia
added
the
State manager
Codecov Report
@@ Coverage Diff @@
## state-manager #775 +/- ##
=================================================
+ Coverage 93.17% 93.19% +0.01%
=================================================
Files 223 224 +1
Lines 3809 3819 +10
Branches 1189 1194 +5
=================================================
+ Hits 3549 3559 +10
Misses 260 260
Continue to review full report at Codecov.
|
rvsia
force-pushed
the
convertInitialValue
branch
from
48547a9 to
4083573
Compare
Hyperkid123
reviewed
Sep 2, 2020
| import convertType from './convert-type'; | ||
| import { DataType } from '../types/data-types'; | ||
|
|
||
| const convertValue = (value: any, dataType: DataType): any => { |
There was a problem hiding this comment.
This should only return a type specified in the dataTypes constant. Not any.
There was a problem hiding this comment.
With arrays and objects.. it's basically any. :D But I changed that.
rvsia
force-pushed
the
convertInitialValue
branch
from
073853b to
971f5c6
Compare
Hyperkid123
approved these changes
Sep 2, 2020
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on Demo can be found here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #771