Skip to content

Redirect on examples when no mapper #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

Redirect on examples when no mapper #782

merged 1 commit into from
Sep 3, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Sep 3, 2020

  • this should prevent algolia to index MUI components twice in the search index

@rvsia rvsia added docs docs pull requests Technical debt labels Sep 3, 2020
@rvsia rvsia requested a review from Hyperkid123 September 3, 2020 07:56
@rvsia
Redirect on examples when no mapper
d6e0062 
- this should prevent algolia to index MUI components twice in the search index
@rvsia rvsia force-pushed the redirectWhenNoMapper branch from 069cf21 to d6e0062 Compare September 3, 2020 08:02
@codecov
Copy link

codecov bot commented Sep 3, 2020 •
edited
Loading

Codecov Report

Merging #782 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files         212      212           
  Lines        3322     3322           
  Branches     1082     1082           
=======================================
  Hits         3080     3080           
  Misses        242      242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f1b46...d6e0062. Read the comment docs.

Hyperkid123
Hyperkid123 approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

We will see

@Hyperkid123 Hyperkid123 merged commit fac2106 into data-driven-forms:master Sep 3, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.8.19 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the redirectWhenNoMapper branch October 7, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees

@Hyperkid123 Hyperkid123

Labels
docs docs pull requests released Technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvsia @Hyperkid123