Skip to content

fix(carbon): fix styles for wizard/subform/tabs #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Oct 9, 2020

These three components were missing the form spacing

Before

image

After

image

@rvsia rvsia added bug Something isn't working Carbon PRs/Issues for IBM's Carbon design system labels Oct 9, 2020
@rvsia rvsia requested a review from Hyperkid123 October 9, 2020 13:23
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #827 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   93.27%   93.28%           
=======================================
  Files         233      233           
  Lines        3571     3574    +3     
  Branches     1156     1158    +2     
=======================================
+ Hits         3331     3334    +3     
  Misses        240      240           
Impacted Files Coverage Δ
...ages/carbon-component-mapper/src/files/sub-form.js 100.00% <100.00%> (ø)
packages/carbon-component-mapper/src/files/tabs.js 100.00% <100.00%> (ø)
...ckages/carbon-component-mapper/src/files/wizard.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2591e5...da5ce08. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 8d7ae57 into data-driven-forms:master Oct 12, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.10.1 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Carbon PRs/Issues for IBM's Carbon design system released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants