Skip to content

fix(pf4): add class for cancel wizard button #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2021
Merged

fix(pf4): add class for cancel wizard button #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/pf4-component-mapper/src/files/wizard/step-buttons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,11 @@ const WizardStepButtons = ({
<Button type="button" variant="secondary" isDisabled={disableBack} onClick={handlePrev}>
{back}
</Button>
<Button type="button" variant="link" onClick={formOptions.onCancel}>
{cancel}
</Button>
<div className="pf-c-wizard__footer-cancel">
<Button type="button" variant="link" onClick={formOptions.onCancel}>
{cancel}
</Button>
</div>
</React.Fragment>
)}
</FormSpy>
Expand Down
72 changes: 40 additions & 32 deletions packages/pf4-component-mapper/src/tests/wizard/__snapshots__/step-buttons.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,26 +83,30 @@ exports[`<WizardSTepButtons should add custom className to toolbar 1`] = `
Back
</button>
</Button>
<Button
onClick={[MockFunction]}
type="button"
variant="link"
<div
className="pf-c-wizard__footer-cancel"
>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-2"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
<Button
onClick={[MockFunction]}
role={null}
type="button"
variant="link"
>
Cancel
</button>
</Button>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-2"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
onClick={[MockFunction]}
role={null}
type="button"
>
Cancel
</button>
</Button>
</div>
</FormSpy>
</footer>
</WizardStepButtons>
Expand Down Expand Up @@ -192,26 +196,30 @@ exports[`<WizardSTepButtons should render correctly 1`] = `
Back
</button>
</Button>
<Button
onClick={[MockFunction]}
type="button"
variant="link"
<div
className="pf-c-wizard__footer-cancel"
>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-1"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
<Button
onClick={[MockFunction]}
role={null}
type="button"
variant="link"
>
Cancel
</button>
</Button>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-1"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
onClick={[MockFunction]}
role={null}
type="button"
>
Cancel
</button>
</Button>
</div>
</FormSpy>
</footer>
</WizardStepButtons>
Expand Down
108 changes: 60 additions & 48 deletions packages/pf4-component-mapper/src/tests/wizard/__snapshots__/wizard-step.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,26 +173,30 @@ exports[`<WizardStep /> should render correctly 1`] = `
Back
</button>
</Button>
<Button
onClick={[MockFunction]}
type="button"
variant="link"
<div
className="pf-c-wizard__footer-cancel"
>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-1"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
<Button
onClick={[MockFunction]}
role={null}
type="button"
variant="link"
>
Cancel
</button>
</Button>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-1"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
onClick={[MockFunction]}
role={null}
type="button"
>
Cancel
</button>
</Button>
</div>
</FormSpy>
</footer>
</WizardStepButtons>
Expand Down Expand Up @@ -381,26 +385,30 @@ exports[`<WizardStep /> should render custom description 1`] = `
Back
</button>
</Button>
<Button
onClick={[MockFunction]}
type="button"
variant="link"
<div
className="pf-c-wizard__footer-cancel"
>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-5"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
<Button
onClick={[MockFunction]}
role={null}
type="button"
variant="link"
>
Cancel
</button>
</Button>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-5"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
onClick={[MockFunction]}
role={null}
type="button"
>
Cancel
</button>
</Button>
</div>
</FormSpy>
</footer>
</WizardStepButtons>
Expand Down Expand Up @@ -618,26 +626,30 @@ exports[`<WizardStep /> should render title with showTitle 1`] = `
Back
</button>
</Button>
<Button
onClick={[MockFunction]}
type="button"
variant="link"
<div
className="pf-c-wizard__footer-cancel"
>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-2"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
<Button
onClick={[MockFunction]}
role={null}
type="button"
variant="link"
>
Cancel
</button>
</Button>
<button
aria-disabled={false}
aria-label={null}
className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-link-2"
data-ouia-component-type="PF4/Button"
data-ouia-safe={true}
disabled={false}
onClick={[MockFunction]}
role={null}
type="button"
>
Cancel
</button>
</Button>
</div>
</FormSpy>
</footer>
</WizardStepButtons>
Expand Down
Loading