CDAP-19389: Show correct SQL Datetime type for source table during Assessment #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitjnn
changed the title
6 tasks
sumitjnn
force-pushed
the
datetime-assess
branch
from
10553a5 to
e681032
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
sumitjnn
requested review from
itsankit-google,
sahusanket and
seanzhougoogle
sahusanket
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue in review assessment step, but not in "select table and transformation" as we use different fields from API responses in UI code. PR for fixing UI inconsistency cdapio/cdap-ui#831