Skip to content

Maintainance (2024-11-27) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 27, 2024
Merged

Maintainance (2024-11-27) #95

merged 21 commits into from
Nov 27, 2024

Conversation

pan93412
Copy link
Member

@pan93412 pan93412 commented Nov 27, 2024 •
edited
Loading

Remarks:

  • Adapt for EasyAdmin "Pretty URL" feature.
    • docker: refresh the broken cache of Symfony when building
    • admin: remove batch actions (unsupported in Pretty URL)
    • events: use Pretty URL to the feedback URL
  • Replace deprecated icon names in EasyAdmin
  • Lazy-loading and remove unneeded components.
    • chart.js: mark to lazy load
    • bootstrap: refactor SCSS structure
    • bootstrap: leave only the components we do use
    • controllers: only load Bootstrap when we need it
    • challenge/executor: lazy loading CodeMirror editor
    • remove reduntant import and await
  • Reindex the questions when the question is updated
  • Migrate to SQL runner v2: https://github.com/database-playground/sqlrunner-v2
    • Drop out LockFactory since SQL runner v2 handles it well

@pan93412 pan93412 self-assigned this Nov 27, 2024
@pan93412
feat: Implement SQL Runner SDK
dceb066
@pan93412
refactor!: Migrate to new SQL Runner
79b17dd 
Also fix some bugs in SQL Runner SDK:

* Simplify exceptions (500 -> RunnerException)
* getContent() should not throws on non-200 errors
* Fix payload JSON casting
@pan93412
chore: Install cURL extension to improve HTTP performance
c209037
@pan93412
docs: Note about "sqlrunner" deployment
ed671e6
@pan93412
refactor!: Remove old dbrunner completely
7c5757b
@pan93412 pan93412 changed the title Maintaince (2024-11-27) Maintainance (2024-11-27) Nov 27, 2024
@pan93412 pan93412 marked this pull request as ready for review November 27, 2024 18:31
@pan93412 pan93412 merged commit 31d48e5 into master Nov 27, 2024
2 checks passed
@pan93412 pan93412 deleted the maintainance-241127 branch November 27, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pan93412 pan93412

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pan93412