Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Enforce all deps must be declared at root #16741

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 31, 2024

Signed-off-by: Xuanwo github@xuanwo.ioI hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR is used to enforce all deps must be declared at root.

After this PR, developers must use workspace = true to specify crate version.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 31, 2024
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo enabled auto-merge October 31, 2024 10:18
@Xuanwo Xuanwo added this pull request to the merge queue Oct 31, 2024
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo removed this pull request from the merge queue due to a manual request Oct 31, 2024
@Xuanwo Xuanwo enabled auto-merge October 31, 2024 10:33
@Xuanwo Xuanwo added this pull request to the merge queue Oct 31, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 31, 2024
@BohuTANG BohuTANG merged commit 9c2c3dd into databendlabs:main Oct 31, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants