Skip to content

fix: config rename for file logging max_size #18772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: config rename for file logging max_size #18772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb9649e
fix: config rename for file logging max_size
everpcpc Sep 24, 2025
9a6ab33
z
everpcpc Sep 24, 2025
a23a3d1
Merge branch 'main' into fix-config
everpcpc Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/meta/service/src/configs/outer_v0.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ pub struct FileLogConfig {

/// Log file max size, default is 4GB
#[clap(long = "log-file-max-size", default_value = "4294967296")]
#[serde(rename = "max-size")]
#[serde(rename = "max_size")]
pub file_max_size: usize,

/// Deprecated fields, used for catching error, will be removed later.
Expand Down
2 changes: 1 addition & 1 deletion src/query/config/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2413,7 +2413,7 @@ pub struct FileLogConfig {
value_name = "VALUE",
default_value = "4294967296"
)]
#[serde(rename = "max-size")]
#[serde(rename = "max_size")]
pub file_max_size: usize,

/// Deprecated fields, used for catching error, will be removed later.
Expand Down
2 changes: 1 addition & 1 deletion src/query/service/tests/it/storages/testdata/configs_table_basic.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ DB.Table: 'system'.'configs', Table: configs-table_id:1, ver:0, Engine: SystemCo
| 'log' | 'file.format' | 'text' | '' |
| 'log' | 'file.level' | 'WARN,databend=DEBUG,openraft=DEBUG' | '' |
| 'log' | 'file.limit' | '48' | '' |
| 'log' | 'file.max-size' | '4294967296' | '' |
| 'log' | 'file.max_size' | '4294967296' | '' |
| 'log' | 'file.on' | 'true' | '' |
| 'log' | 'file.prefix_filter' | 'null' | '' |
| 'log' | 'history.interval' | '2' | '' |
Expand Down
Loading