Improve the output of the databricks bundle init command
#795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennartkats-db
force-pushed
the
tune-template-output
branch
from
a4d7ad9
to
def37e9
Compare
lennartkats-db
changed the title
databricks bundle init command
shreyas-goenka
requested changes
Sep 26, 2023
Co-authored-by: shreyas-goenka <88374338+shreyas-goenka@users.noreply.github.com>
… tune-template-output
pietern
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Nice work, LGTM!
@mingyu89 @vladimirk-db Once this is merged and released, you could consider adding a message to the MLops stack template. Nice to have a call to action after initialization.
@shreyas-goenka Can you do the final approval?
Remove snake_case comment
shreyas-goenka
approved these changes
Oct 3, 2023
|
I'll followup, needed to prioritize some roadmap/serverless work. |
shreyas-goenka
added a commit
that referenced
this pull request
Oct 19, 2023
CLI: * Fix rendering of streaming response ([#876](#876)). * Rename MLOps Stack to MLOps Stacks ([#881](#881)). * Support Python wheels larger than 10MB ([#879](#879)). * Improve the output of the `databricks bundle init` command ([#795](#795)). Bundles: * **FILL THIS IN MANUALLY BY MOVING RELEVANT ITEMS FROM ABOVE LIST** Internal: * **FILL THIS IN MANUALLY BY MOVING RELEVANT ITEMS FROM ABOVE LIST**
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
## Changes This PR removes validation for default value against the regex pattern specified in a JSON schema at schema load time. This is required because #795 introduces parameterising the default value as a Go text template impling that the default value now does not necessarily have to match the pattern at schema load time. This will also unblock: databricks/mlops-stacks#108 Note, this does not remove runtime validation for input parameters right before template initialization, which happens here: https://github.com/databricks/cli/blob/fb32e78c9b9fb000ce898b8a60b0b47920f487d3/libs/template/materialize.go#L76 ## Tests Changes to existing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the output of help, prompts, and so on for
databricks bundle initand the default template.Among other things, this PR adds support for a new
welcome_messageproperty that lets a template print a custom message on success: