Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python wheels larger than 10MB #879

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Support Python wheels larger than 10MB #879

merged 2 commits into from
Oct 18, 2023

Conversation

andrewnester
Copy link
Contributor

Changes

Previously we only supported uploading Python wheels smaller than 10mb due to using Workspace.Import API and content field https://docs.databricks.com/api/workspace/workspace/import

By switching to use WorkspaceFilesClient we overcome the limit because it uses POST body for the API instead.

Tests

TestAccUploadArtifactFileToCorrectRemotePath integration test passes

=== RUN   TestAccUploadArtifactFileToCorrectRemotePath
    artifacts_test.go:28: gcp
2023/10/17 15:24:04 INFO Using Google Credentials sdk=true
    helpers.go:356: Creating /Users/.../integration-test-wsfs-ekggbkcfdkid
artifacts.Upload(test.whl): Uploading...
2023/10/17 15:24:06 INFO Using Google Credentials mutator=artifacts.Upload(test) sdk=true
artifacts.Upload(test.whl): Upload succeeded
    helpers.go:362: Removing /Users/.../integration-test-wsfs-ekggbkcfdkid
--- PASS: TestAccUploadArtifactFileToCorrectRemotePath (5.66s)
PASS
coverage: 14.9% of statements in ./...
ok      github.com/databricks/cli/internal      6.109s  coverage: 14.9% of statements in ./...

pietern
pietern reviewed Oct 18, 2023
View reviewed changes
bundle/artifacts/artifacts.go Show resolved Hide resolved
internal/artifacts_test.go Outdated Show resolved Hide resolved
@pietern pietern changed the title Support Python wheels larger than 10mb Support Python wheels larger than 10MB Oct 18, 2023
@andrewnester andrewnester added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 5273d0c Oct 18, 2023
4 checks passed
@andrewnester andrewnester deleted the larger-wheel branch October 18, 2023 10:26
shreyas-goenka added a commit that referenced this pull request Oct 19, 2023
@shreyas-goenka
Release v0.208.1
1666af6 
CLI:
 * Fix rendering of streaming response ([#876](#876)).
 * Rename MLOps Stack to MLOps Stacks ([#881](#881)).
 * Support Python wheels larger than 10MB ([#879](#879)).
 * Improve the output of the `databricks bundle init` command ([#795](#795)).

Bundles:
 * **FILL THIS IN MANUALLY BY MOVING RELEVANT ITEMS FROM ABOVE LIST**

Internal:
 * **FILL THIS IN MANUALLY BY MOVING RELEVANT ITEMS FROM ABOVE LIST**
@shreyas-goenka shreyas-goenka mentioned this pull request Oct 19, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 19, 2023
@shreyas-goenka
Release v0.208.1 (#887)
ec94254 
CLI:
* Fix rendering of streaming response
([#876](#876)).
 
Bundles:
* Rename MLOps Stack to MLOps Stacks
([#881](#881)).
* Support Python wheels larger than 10MB
([#879](#879)).
* Improve the output of the `databricks bundle init` command
([#795](#795)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewnester @pietern