Removed experimental redacting logger filter for dbutils.secrets.get('scope', 'key')
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removing experimental basic, best-effort, logging filter to redact secrets from accidental logging. `sys.stdout`, `sys.stderr`, and `print()` statements are not handled. This won't work anymore: <img width="1083" alt="databricks-sdk-py_–_test_dbutils_py" src="https://user-images.githubusercontent.com/259697/227218521-0a4f14f8-8445-4a6b-9f6f-ecc073e43524.png">
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 52.80% 52.72% -0.09%
==========================================
Files 29 29
Lines 17103 17065 -38
==========================================
- Hits 9032 8998 -34
+ Misses 8071 8067 -4
☔ View full report in Codecov by Sentry. |
kartikgupta-db
approved these changes
May 5, 2023
nfx
changed the title
dbutils.secrets.get('scope', 'key')
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It seems that
dbutils.secrets.get('scope', 'key')is conflicting with internal working of Jupyter Kernel.This PR removing experimental basic, best-effort, logging filter to redact secrets from accidental logging.
sys.stdout,sys.stderr, andprint()statements are not handled.This won't work anymore:
Tests
make testrun locallymake fmtapplied