Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error handling for SCIM and CommandExecution APIs #94

Merged
merged 1 commit into from
May 5, 2023
Merged

Fixed error handling for SCIM and CommandExecution APIs #94

merged 1 commit into from
May 5, 2023

Conversation

nfx
Copy link
Contributor

@nfx nfx commented May 5, 2023

Changes

  • DatabricksError and _make_nicer_error were not integration tested before
  • this PR adds proper kwarg resolution

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@nfx
Fixed error handling for SCIM and CommandExecution APIs
a777b4c 
- `DatabricksError` and `_make_nicer_error` were not integration tested before
- this PR adds proper kwarg resolution
@nfx nfx requested a review from a team May 5, 2023 14:56
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.09 ⚠️

Comparison is base (de99f32) 52.80% compared to head (a777b4c) 52.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   52.80%   52.72%   -0.09%     
==========================================
  Files          29       29              
  Lines       17103    17067      -36     
==========================================
- Hits         9032     8998      -34     
+ Misses       8071     8069       -2
Impacted Files Coverage Δ
databricks/sdk/dbutils.py 92.48% <ø> (+0.66%) ⬆️
databricks/sdk/core.py 65.65% <42.85%> (-0.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nfx nfx linked an issue May 5, 2023 that may be closed by this pull request
Error while using filter parameter in list operation #90
Closed
@nfx nfx merged commit 09f45f0 into main May 5, 2023
@nfx nfx deleted the fix/90 branch May 5, 2023 14:59
@nfx nfx mentioned this pull request May 5, 2023
Merged
nfx added a commit that referenced this pull request May 5, 2023
@nfx
Release v0.1.4 (#95)
c42296e 
# Version changelog

## 0.1.4

* Removed experimental redacting logger filter for
`dbutils.secrets.get('scope', 'key')`, that was causing Jupyter Kernels
to hang
([#92](#92)).
* Fixed error handling for SCIM and CommandExecution APIs
([#94](#94)).
* Created `dependabot.yml`
([#89](#89)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while using filter parameter in list operation
2 participants
@nfx @codecov-commenter