--no-color is not working

[luisdavim]

I always get a colorful output regardless of passing the --no-color flag or not.

[mumoshu]

@luisdavim Ah, good catch!

It seems like helm-diff should use the global variables instead of string literals of color names, so that ansi.DisableColors takes effect:

helm-diff/cmd/root.go

Lines 40 to 42 in 49879b1

	if nc, _ := cmd.Flags().GetBool("no-color"); nc {
	ansi.DisableColors(true)
	}

That is, I think we should change "yellow" like seen in the below example to ansi.Yellow:

helm-diff/diff/diff.go

Line 22 in 05029fe

fmt.Fprintf(to, ansi.Color("%s has changed:", "yellow")+"\n", key)

[vwagner]

Same problem. We post the helm diff to slack when someone upgrades the cluster. Slack post looks terrible because of color-code markup:

[databus23]

The problem is caused by using PersistentPreRun multiple times (in parent command and child).
From the spf13/cobra README:

The Persistent*Run functions will be inherited by children if they do not declare their own.

Fixing

[vwagner]

Thanks @databus23 . I can remove my "fix" now:

echo $text | sed 's/\.\.\./...|/g' | sed -e 's/\[0m/|/g' | sed -e 's/\[3.m//g' | tr '|' '\n'

ugghhhhhh