fix report concurrency crash when helm-diff used as a library #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Ok, sorry for letting this slide. LGTM. Would you mind rebasing it so it can be merged. |
the Manifests codepath was calling setupReportFormat on a mutable global map, which means that calling Manifests from different gothreads is an error, and can produce a panic with this (abbreviated) traceback: fatal error: concurrent map writes goroutine 668 [running]: runtime.throw(0x27cb973, 0x15) /usr/local/go/src/runtime/panic.go:1116 +0x72 fp=0xc003a8c710 sp=0xc003a8c6e0 pc=0x437892 runtime.mapassign_faststr(0x23fc3a0, 0xc019650120, 0x27a837d, 0x6, 0xc00012f408) /usr/local/go/src/runtime/map_faststr.go:211 +0x3f1 fp=0xc003a8c778 sp=0xc003a8c710 pc=0x414811 github.com/databus23/helm-diff/v3/diff.setupDiffReport(...) /go/pkg/mod/github.com/databus23/helm-diff/v3@v3.1.3/diff/report.go:99 github.com/databus23/helm-diff/v3/diff.(*Report).setupReportFormat(0x3dafe80, 0x27a5ada, 0x4) /go/pkg/mod/github.com/databus23/helm-diff/v3@v3.1.3/diff/report.go:67 +0x111 fp=0xc003a8c7b0 sp=0xc003a8c778 pc=0x20e7291 github.com/databus23/helm-diff/v3/diff.Manifests(0xc009ffaf60, 0xc009ffb3e0, 0xc0061f73e0, 0x1, 0x1, 0xc0061f7300, 0x5, 0x27a5ada, 0x4, 0x2b26460, ...)
|
Rebased. |
|
(ping @databus23) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
mumoshu
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Manifests codepath was calling setupReportFormat on a mutable global map,
which means that calling Manifests from different gothreads is an error,
and can produce a panic with this (abbreviated) traceback: