Skip to content

Use releases/latest url instead api to get lastest artifact #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jun 6, 2021

Reduce extra calls the gh API

% curl -sI https://github.com/databus23/helm-diff/releases/latest/download/helm-diff-windows.tgz | grep location:
location: https://github.com/databus23/helm-diff/releases/download/v3.1.3/helm-diff-windows.tgz

Fixes #284

@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 6, 2021
@jkroepke
Copy link
Contributor Author

.

@stale stale bot removed the stale label Sep 13, 2021
@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2022
@stale stale bot removed the stale label Jan 8, 2022
@mumoshu
Copy link
Collaborator

mumoshu commented Jan 8, 2022

Nice! I added -$ARCH to the URL as we've recently started publishing arch-specific archives, mainly for M1 mac support.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @jkroepke ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awk warning on helm plugin install
2 participants