Skip to content

Fix for Install-Binary script #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2022
Merged

Fix for Install-Binary script #307

merged 2 commits into from
Jan 8, 2022

Conversation

Hammond95
Copy link
Contributor

@Hammond95 Hammond95 commented Sep 14, 2021 •
edited
Loading

The script failed because of some conditions assumed true, fixed as follow:

  • if HELM_BIN is not set the just uses helm path
  • helm home command doesn't seem to exist on helm3.x, using a default path if this is the case
  • tgz downloaded file wasn't extracted properly

resolves #244

@Hammond95 Hammond95 marked this pull request as draft September 14, 2021 21:25
@Hammond95 Hammond95 marked this pull request as ready for review September 14, 2021 22:00
@Hammond95
Copy link
Contributor Author

Hammond95 commented Dec 17, 2021 •
edited
Loading

@databus23, @mumoshu, sorry to bother you, any chance you can give a look at my PR? Also, I would like to help maintain this project, would this be possible?

mumoshu
mumoshu approved these changes Jan 8, 2022
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lack comprehensive test cases to verify this doesn't break anything. But it looks good to me so let's try! Thanks for your patience and contribution ☺️

@mumoshu mumoshu merged commit 9ec583c into databus23:master Jan 8, 2022
@mumoshu
Copy link
Collaborator

mumoshu commented Jan 8, 2022

I've verified that helm plugin install on helm-diff does work without --version flag after this change. Probably it's good.

@michaelsauter michaelsauter mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin does not install if helm is helm 3 but run from helm 2
2 participants
@Hammond95 @mumoshu