Skip to content

Ensure values files exist #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2018
Merged

Ensure values files exist #33

merged 1 commit into from
Apr 11, 2018

Conversation

foklepoint
Copy link
Contributor

@foklepoint foklepoint commented Apr 3, 2018 •
edited
Loading

Ensures that a value file actually exists instead of throwing up a golang exception when trying to open a file that doesn't exist

@foklepoint foklepoint changed the title ensure values files exist Ensure values files exist Apr 3, 2018
@foklepoint
Copy link
Contributor Author

@databus23 Can we please get this merged and cut a new version?

gtaylor
gtaylor approved these changes Apr 3, 2018
View reviewed changes
Copy link

@gtaylor gtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been running this in prod for a while!

@sstarcher
Copy link
Contributor

@databus23 Pinged you on slack I understand if you don't have time, but would love to see this get merged.

@databus23 databus23 merged commit 885e7a7 into databus23:master Apr 11, 2018
@databus23
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gtaylor gtaylor gtaylor approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foklepoint @sstarcher @databus23 @gtaylor