bump go from 1.18 to 1.19 and bump to helm 3.11.3 #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about the current process. @mumoshu would you review? |
mumoshu
reviewed
Apr 23, 2023
tbugfinder
changed the title
|
Merge conflicts were resolved and go.mod/go.sum updated. Hm, now ending up in: |
|
@tbugfinder Thanks for rebasing!
We probably need to bump k8s.io deps to v0.26.x as apparently those are required by helm 3.11.3 https://github.com/helm/helm/blob/66a969e7cc08af2377d055f4e6283c33ee84be33/go.mod#L38-L43 |
tbugfinder
force-pushed
the
security/update-go-mod
branch
from
beb2cc1 to
0db3ad0
Compare
|
I've pushed a less aggressive update to go.mod :-D |
|
@mumoshu could the workflow run be approved? |
|
@mumoshu Could you please merge this PR? Thanks |
mumoshu
approved these changes
May 16, 2023
There was a problem hiding this comment.
LGTM. Thanks a lot for your patience and contribution @tbugfinder!!
hexcsl
pushed a commit
to hexcsl/helm-diff
that referenced
this pull request
Jul 3, 2023
* bump go from 1.17 to 1.19 * bump helm version and dependencies * update circleci image * update working directory to a writeable target * update to helm v3.11.3 --------- Co-authored-by: tbugfinder <tbugfinder@online.ms>
hexcsl
pushed a commit
to hexcsl/helm-diff
that referenced
this pull request
Jul 3, 2023
* bump go from 1.17 to 1.19 * bump helm version and dependencies * update circleci image * update working directory to a writeable target * update to helm v3.11.3 --------- Co-authored-by: tbugfinder <tbugfinder@online.ms>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.