refactor(helm3): optimize manifest extraction logic #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yxxhero <aiopsclub@163.com>
|
@mumoshu WDYT? |
yxxhero
deleted the
795-helm_diff_use_upgrade_dry_runtrue-crashes-helm-when-no-deployment-exists-in-target-namespace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
extractManifestFromHelmUpgradeDryRunOutputfunction incmd/helm3.goto improve its handling of edge cases. Specifically, it ensures that the function properly checks for the presence of "HOOKS" and "MANIFEST" sections before attempting to extract them.Enhancements to edge case handling:
cmd/helm3.go: Added conditional checks to verify the existence of "HOOKS" and "MANIFEST" sections before extracting their contents, preventing potential issues with invalid input.