Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CX-1204] Fix: check higher order function arguments #391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[CX-1204] Fix: check higher order function arguments #391

wants to merge 2 commits into from

Conversation

hermansje
Copy link
Member

Ticket

Link to ticket: https://datacamp.atlassian.net/browse/CX-1204

What has been done

  • Allow adding () to a the name argument for check_function to differentiate between checking a call and a higher order call.

Notes

  • This PR builds on [CX-1182] Feat: lazychain #389, so the full diff includes those changes as well.
  • This change breaks existing exercises that check the higher order call arguments, so rollout needs to be synced with content.

@hermansje hermansje self-assigned this Jan 14, 2020
TimSangster
TimSangster approved these changes May 24, 2020
View reviewed changes
Copy link
Contributor

@TimSangster TimSangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much extra functionality with so little code, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSangster TimSangster TimSangster approved these changes

Assignees

@hermansje hermansje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hermansje @TimSangster