Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NextJS #321

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Upgrade NextJS #321

merged 11 commits into from
Jan 31, 2024

Conversation

bklaing2
Copy link
Member

@bklaing2 bklaing2 commented Jan 25, 2024

Purpose

Upgraded NextJS from version 12 to 13

As a side effect, react, react-dom, (and their types), and cypress needed to be upgraded.
This caused the react-bootstrap overlay trigger to throw an error, as it wasn't compatible with the updated version of react. I implemented this fix.

Open Questions and Pre-Merge TODOs

Other things to note

  • When running with NODE_ENV=test, there was an error. The only place that NODE_ENV=test was set was in the Cypress tests Github action. I replaced NODE_ENV with CYPRESS_NODE_ENV, and the error went away.
    • As far as I can tell, our Cypress test don't care what the NODE_ENV is anyways
  • next-usequerystate is being renamed to nuqs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2 bklaing2 requested a review from jrhoads January 25, 2024 11:53
@bklaing2 bklaing2 changed the title Upgraded NextJS from 12 to 13 Upgrade NextJS from 12 to 13 Jan 25, 2024
Copy link

cypress bot commented Jan 29, 2024

1 flaky test on run #1032 ↗︎

0 64 0 0 Flakiness 1

Details:

Merge 2a9226e into 60a5a79...
Project: akita Commit: 8c7bbba726 ℹ️
Status: Passed Duration: 02:26 💡
Started: Jan 31, 2024 3:48 PM Ended: Jan 31, 2024 3:50 PM
Flakiness  cypress/e2e/personContainer.test.ts • 1 flaky test • Tests

View Output

Test Artifacts
PersonContainer > production chart Test Replay Screenshots

Review all test suite changes for PR #321 ↗︎

@bklaing2 bklaing2 self-assigned this Jan 29, 2024
@bklaing2 bklaing2 changed the title Upgrade NextJS from 12 to 13 Upgrade NextJS Jan 31, 2024
@bklaing2 bklaing2 marked this pull request as ready for review January 31, 2024 15:40
@bklaing2 bklaing2 merged commit bfdbdd0 into master Jan 31, 2024
10 of 11 checks passed
@bklaing2 bklaing2 deleted the upgrade-nextjs branch January 31, 2024 16:18
This was referenced Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants