-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade NextJS #321
Merged
Merged
Upgrade NextJS #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #1032 ↗︎
Details:
cypress/e2e/personContainer.test.ts • 1 flaky test • Tests
Review all test suite changes for PR #321 ↗︎ |
* Upgraded NextJS from 13 to 14 * Removed legacyBehavior from links
bklaing2
force-pushed
the
upgrade-nextjs
branch
from
January 31, 2024 15:46
b18e985
to
2a9226e
Compare
jrhoads
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgraded NextJS from version 12 to 13
As a side effect, react, react-dom, (and their types), and cypress needed to be upgraded.
This caused the react-bootstrap overlay trigger to throw an error, as it wasn't compatible with the updated version of react. I implemented this fix.
Open Questions and Pre-Merge TODOs
<Link>
components in version 13 no longer allow<a>
tags to be children. I've added thelegacyBehavior
to each link to ignore this for now.useEffect
to the doi, org, person, and repo search pages due to hydration issues. More research is needed to find a proper solution to this issue.Other things to note
NODE_ENV=test
, there was an error. The only place thatNODE_ENV=test
was set was in the Cypress tests Github action. I replacedNODE_ENV
withCYPRESS_NODE_ENV
, and the error went away.next-usequerystate
is being renamed tonuqs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: