Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NextJS from 13 to 14 #326

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

bklaing2
Copy link
Member

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2 bklaing2 requested a review from jrhoads January 29, 2024 11:16
@bklaing2 bklaing2 self-assigned this Jan 29, 2024
Copy link

cypress bot commented Jan 29, 2024

1 flaky test on run #1020 ↗︎

0 64 0 0 Flakiness 1

Details:

Upgraded NextJS from 13 to 14
Project: akita Commit: e0e2dffb14
Status: Passed Duration: 02:42 💡
Started: Jan 29, 2024 11:18 AM Ended: Jan 29, 2024 11:21 AM
Flakiness  cypress/e2e/personContainer.test.ts • 1 flaky test • Tests

View Output

Test Artifacts
PersonContainer > links Test Replay Screenshots

Review all test suite changes for PR #326 ↗︎

@bklaing2 bklaing2 mentioned this pull request Jan 29, 2024
6 tasks
@bklaing2 bklaing2 marked this pull request as ready for review January 31, 2024 15:35
@bklaing2 bklaing2 merged commit b18e985 into upgrade-nextjs Jan 31, 2024
4 checks passed
@bklaing2 bklaing2 deleted the upgrade-nextjs-13-to-14 branch January 31, 2024 15:37
bklaing2 added a commit that referenced this pull request Jan 31, 2024
* Upgraded NextJS from 13 to 14

* Removed legacyBehavior from links
bklaing2 added a commit that referenced this pull request Jan 31, 2024
* Upgraded NextJS from 12 to 13

* Upgraded Cypress

* Upgraded Cypress

* Fixed ReactDOM.unstable_renderSubtreeIntoContainer error caused by react-bootstrap

* Fixed broken tests

* Fixed build error

* Added useEffect fix to index page

* Changed NODE_ENV to CYPRESS_NODE_ENV

* next-usequerystate is being renamed to 'nuqs'

* Changed NODE_ENV to CYPRESS_NODE_ENV

* Upgrade NextJS from 13 to 14 (#326)

* Upgraded NextJS from 13 to 14

* Removed legacyBehavior from links
This was referenced Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants