Ant Design Table changes #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guzman-raphael
requested changes
Aug 23, 2022
There was a problem hiding this comment.
@zitrosolrac @jverswijver Submitting initial review. Nice work guys!
| for comp_name, comp in ( | ||
| grid["component_templates"] | ||
| if "component_templates" in grid | ||
| else grid["components"] | ||
| ).items(): | ||
| if re.match( | ||
| r"^(table|metadata|plot|file|slider|dropdown-query).*$", | ||
| r"^(table|djtable|metadata|plot|file|slider|dropdown-query).*$", |
There was a problem hiding this comment.
Suggested change
| r"^(table|djtable|metadata|plot|file|slider|dropdown-query).*$", | |
| r"^(table|antd-table|metadata|plot|file|slider|dropdown-query).*$", |
| @@ -322,6 +348,7 @@ def dj_query_route(self): | |||
| "basicquery": BasicQuery, | |||
| "plot:plotly:stored_json": PlotPlotlyStoredjsonComponent, | |||
| "table": TableComponent, | |||
| "djtable": TableComponent, | |||
There was a problem hiding this comment.
Suggested change
| "djtable": TableComponent, | |
| "antd-table": TableComponent, |
| @@ -287,12 +306,19 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
| def dj_query_route(self): | |||
| fetch_metadata = self.fetch_metadata | |||
| print(request.args, flush=True) | |||
There was a problem hiding this comment.
Suggested change
| print(request.args, flush=True) |
Comment on lines
+41
to
+42
| if type(o) is UUID: | ||
| return str(o) |
There was a problem hiding this comment.
Suggested change
| if type(o) is UUID: | |
| return str(o) | |
| if type(o) is UUID: | |
| return str(o) | |
| if type(o) is str and o == "NaN": | |
| return None |
| return json.JSONEncoder.default(self, o) | ||
|
|
||
| @classmethod | ||
| def dumps(cls, obj): | ||
| return json.dumps(obj, cls=cls) | ||
| return json.dumps(obj, cls=cls).replace("NaN", "null") |
There was a problem hiding this comment.
Suggested change
| return json.dumps(obj, cls=cls).replace("NaN", "null") | |
| return json.dumps(obj, cls=cls) |
| @@ -77,7 +80,7 @@ def __init__(self, name, component_config, static_config, jwt_payload: dict): | |||
| self.vm_list = [ | |||
| dj.VirtualModule( | |||
| s, | |||
| s, | |||
| s.replace("__DASH__", "-"), | |||
There was a problem hiding this comment.
Double _ -> - might be a bit easier to work with though the user would need to know this...
Suggested change
| s.replace("__DASH__", "-"), | |
| s.replace("__", "-"), |
Merged
|
Nice work @zitrosolrac. 🤝 Since @jverswijver is cleaning this up and including your commits, I'll go ahead and close this since the other supersedes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.