Workaround datalad gh-3836 #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, that we just need to install that dataset here. We are not testing install/get-behavior of datalad core (cherry picked from commit a663566)
yarikoptic
reviewed
Oct 28, 2019
| # workaround it: | ||
| ds = Dataset(opj(srcrepo.path, 'datalad_neuroimaging', 'tests', 'data', | ||
| 'dicoms', flavor)) | ||
| assert ds.is_installed() |
There was a problem hiding this comment.
I could be wrong, but I feel that it might be quite a common pattern which would keep coming up, and better be resolved in datalad itself instead of breeding workarounds. If anything I would have at least absorbed common "logic" for path into dspath = opj(...) and use dspath in both lines
There was a problem hiding this comment.
Agree - it should be actually solved in datalad. However, I just need to see, whether I found all the spots, where datalad-hirni and its dependencies fail to properly work with rc6.
|
FTR: Addressing this in datalad/datalad#3841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See datalad/datalad#3836
Here we need to just install that subdataset. We are not testing install/get-behavior of datalad core and we don't really care for the result (that is the broken aspect).