Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4 introduced build reproducibility issue #709

Closed
mih opened this issue May 23, 2024 · 0 comments · Fixed by #735
Closed

1.4 introduced build reproducibility issue #709

mih opened this issue May 23, 2024 · 0 comments · Fixed by #735

Comments

@mih
Copy link
Member

mih commented May 23, 2024

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/datalad-next.html

This is caused by the memory address of a function that is the default argument of Dataset.install(result_filter=). See http://docs.datalad.org/projects/next/en/latest/generated/generated/datalad_next.datasets.Dataset.html#datalad_next.datasets.Dataset.install

image

mih added a commit to mih/datalad-next that referenced this issue Jul 1, 2024
This is achieved by a new patch, because the behavior is caused by
datalad-core's tooling.

The approach taken is to delete memory address statements like
'... at 0x...', and delete them via a regex -- similar to what
sphinx is doing for documentation generation.

The patch is not similar to sphinx, but global, because memory addresses
also have little to no utility for runtime documentation too.

This actually affects only a single usage of a function pointer
used as a default argument.

Closes: datalad#709
@mih mih closed this as completed in #735 Jul 1, 2024
@mih mih closed this as completed in 0d2440d Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant